Skip to content

Fix flame initialization#2784

Merged
bigfooted merged 25 commits intodevelopfrom
fix_flame_initialization
Apr 21, 2026
Merged

Fix flame initialization#2784
bigfooted merged 25 commits intodevelopfrom
fix_flame_initialization

Conversation

@bigfooted
Copy link
Copy Markdown
Contributor

@bigfooted bigfooted commented Apr 12, 2026

Proposed Changes

Give a brief overview of your contribution here in a few sentences.
Fix flame initialization and improve warning and error messages. The flame initialization also needs a regression test, with a physical check on temperature (ignition).

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

Comment thread Common/include/CConfig.hpp Outdated
Comment thread Common/include/CConfig.hpp Outdated
Comment thread Common/src/CConfig.cpp Outdated
@bigfooted
Copy link
Copy Markdown
Contributor Author

Thanks, @EvertBunschoten
This PR just needs a regression test now, where the residual output includes some kind of flame temperature at the outlet, so we can check that ignition was successful.

@EvertBunschoten
Copy link
Copy Markdown
Member

Thanks, @EvertBunschoten This PR just needs a regression test now, where the residual output includes some kind of flame temperature at the outlet, so we can check that ignition was successful.

I have just added a regression test which checks if the temperature exceeds the set ignition temperature when using spark and flame front ignition.

@bigfooted bigfooted changed the title [WIP] Fix flame initialization Fix flame initialization Apr 20, 2026
@bigfooted bigfooted merged commit 92ec37e into develop Apr 21, 2026
35 of 36 checks passed
@bigfooted bigfooted deleted the fix_flame_initialization branch April 21, 2026 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants