Skip to content

v2.3 - #142

Merged
bfoujols merged 11 commits into
mainfrom
2.x
Oct 5, 2026
Merged

v2.3#142
bfoujols merged 11 commits into
mainfrom
2.x

Conversation

@bfoujols

@bfoujols bfoujols commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@codacy-production

codacy-production Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

🟢 Coverage 100.00% diff coverage

Metric Results
Coverage variation Report missing for 14700cb1
Diff coverage ✅ 100.00% diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (14700cb) Report Missing Report Missing Report Missing
Head commit (c5d2c94) 909 640 70.41%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#142) 5 5 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

1 Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@deepsource-io

deepsource-io Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

DeepSource Code Review

We reviewed changes in 14700cb...c5d2c94 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
PHP Oct 5, 2026 11:19a.m. Review ↗
Shell Oct 5, 2026 11:19a.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The lockfile is incompatible with declared PHP 8.2 support, and installation and documentation issues remain unresolved.

Review effort: Lite
Findings: 1 Medium severity · 3 Low severity

Open (4)
What changed in this PR

This PR prepares the Edu Framework v2.3 release with updated metadata, documentation, service guidance, and Composer dependencies.

Changes:

  • Adds documentation for SQLite logging, debugging, routing, MailPit, dbgate, and CLI options.
  • Updates release notes, navigation, and project paths.
  • Refreshes Composer dependency constraints and lock data.
File Summary Review notes
src/​EduFramework/​Core/​ConfigCore.php Updates release date metadata. No specific review comment.
docs/​installation/​start-services.md Documents MailPit and dbgate services. Moderate (4 votes): MailPit’s host port mapping conflicts with the documented DSN.
docs/​installation/​start-application.md Documents start options and logging. Nit (1 vote): Qualify the statement that every request is journalized.
docs/​installation/​prerequis.md Adds the SQLite prerequisite. No specific review comment.
docs/​installation/​index.md Updates installation navigation. No specific review comment.
docs/​installation/​command-edu.md Documents start options. No specific review comment.
docs/​changelog.md Adds v2.3 release notes. Nit (3 votes): Release-notes links incorrectly point to v2.4.0.
docs/​build/​use-case-ville.md Corrects configuration paths. No specific review comment.
docs/​build/​use-case-ville-refactor.md Adds route documentation links. No specific review comment.
docs/​build/​controller-edu.md Corrects generated paths. No specific review comment.
docs/​build/​controller-edu-post.md Corrects paths and Twig examples. No specific review comment.
docs/​build/​arborescence.md Documents variable-data directories. No specific review comment.
docs/​boost/​route.md Adds route URL-generation guidance. Nit (1 vote): The standalone example is missing the Route import.
docs/​boost/​index.md Links new Boost guides. No specific review comment.
docs/​boost/​debug-bar.md Documents debug tooling. Nit (4 votes): SQLite is incorrectly described as required for the debug toolbar.
docs/​_summary.md Adds documentation navigation entries. No specific review comment.
composer.lock Refreshes locked dependencies. Critical (4 votes): The lock selects a dependency requiring PHP 8.4.1 despite the declared PHP 8.2 requirement.
composer.json Updates Symfony YAML constraints. No specific review comment.
CHANGELOG.md Updates v2.3 release notes. Nit (4 votes): The release-notes link incorrectly points to v2.4.0.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

La variable d'environnement `MAILER_DSN` de votre fichier `.env` doit pointer vers ce service :

```dotenv
MAILER_DSN="smtp://localhost:1025"
Comment thread CHANGELOG.md Outdated
Comment on lines +30 to +32
> Release notes for v2.4.0
>
> [https://github.com/studoo-app/edu-framework/milestone/v2.3.0](https://github.com/studoo-app/edu-framework/milestone/19)
> [https://github.com/studoo-app/edu-framework/milestone/v2.4.0](https://github.com/studoo-app/edu-framework/milestone/20)
Comment thread docs/boost/debug-bar.md Outdated
Comment thread docs/changelog.md Outdated
bfoujols and others added 7 commits October 5, 2026 11:45
- Updated the minimum required PHP version from 8.2 to 8.4 in the changelog and installation prerequisites.
- Modified example PHP version outputs in the installation prerequisites to reflect PHP 8.4.
- Updated the PHP version in the ConfigCore class to indicate the new minimum requirement.
- Addressed security advisories in symfony/yaml and updated dependencies accordingly.
…épréciation PHP 8.5 et les échecs de FastRouteCoreTest
Corrected formatting and added details about enabling dev mode.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Updated installation instructions and release notes.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…otes de version de 2.4.0 et corriger les problèmes de barre de débogage
…cumentation

- new : page migrate/migration-2_2-2_3.md (PHP 8.4 minimum, extension pdo_sqlite,
  correctifs symfony/yaml, codes HTTP des erreurs, barre de debug, options start,
  MailPit et dbgate)
- update : sommaire (section Migrer) et index des migrations (typo 2.O -> 2.0)
- fix : arborescence.md (compose.json -> compose.yaml)
- changelog : fusion de la section v2.4.0 dans la v2.3.0 (PHP 8.4 rattache a v2.3)
  et ajout de la section documentation
- Remplace les appels sha1() par hash('sha256', ...) pour éviter l'utilisation
d'une fonction obsolète et non sécurisée (sha1 est dépréciée pour les hashs
cryptographiques).
- Met à jour les 9 hashs attendus avec les valeurs sha256 calculées.

Fixes: PHP-A1004 (Use of insecure sha1() function)
@bfoujols
bfoujols merged commit 944a535 into main Oct 5, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants