Fix undefined-method calls flagged by DeepSource (PHP-E1002) in make:* commands - #140
Conversation
|
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| PHP | Oct 5, 2026 8:25a.m. | Review ↗ | |
| Shell | Oct 5, 2026 8:25a.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
Not up to standards ⛔🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 16 |
| Duplication | 0 |
🔴 Coverage 33.33% diff coverage · -2.34% coverage variation
Metric Results Coverage variation ❌ -2.34% coverage variation (-1.00%) Diff coverage ✅ 33.33% diff coverage Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (eea4c04) 907 640 70.56% Head commit (28b5662) 642 (-265) 438 (-202) 68.22% (-2.34%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#140) 9 3 33.33% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Co-authored-by: bfoujols <7000210+bfoujols@users.noreply.github.com>
DeepSource PHP-E1002 flags calls to methods that don't resolve to a definition. In the
make:*commands, two kinds of call were flagged. I fixed these two; I haven't confirmed they are all 14 reported occurrences.addArgumentcasing (CreateCliCommand,CreateApiCommand,CreateControllerCommand)$this->AddArgument(...), but Symfony'sCommanddefinesaddArgument. PHP method names are case-insensitive, so it ran fine, but static analysis can't resolve the call.$this->addArgument(...).getNamesCollectioncall (CreateControllerCommand)execute()calledself::getNamesCollection(...), but the method is a private instance method, not static.$this->getNamesCollection(...).I couldn't run
composer installor the test suite in my environment, and I couldn't see DeepSource's occurrence list. I checked the rest ofsrcby hand and found no other unresolved method calls. Please re-run DeepSource on this branch to see whether any occurrences remain.