Skip to content

hide deprecated widgets from source grid #5842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cmm21 wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −2
Open

hide deprecated widgets from source grid #5842

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions app/components-react/windows/source-showcase/SourceGrid.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,10 @@ export default function SourceGrid(p: { activeTab: string; searchTerm: string })
const customization = useRealmObject(CustomizationService.state);
const demoMode = customization.isDarkTheme ? 'night' : 'day';
const designerMode = customization.designerMode;

/**
* These widgets have been deprecated and are being hidden.
*/
const DEPRECATED_WIDGETS: WidgetType[] = [WidgetType.SubscriberGoal, WidgetType.GameWidget, WidgetType.SupporterGoal, WidgetType.StarsGoal];
/**
* English and languages with logographic writing systems
* generally have shorter strings so we prevent those cards from wrapping.
Expand All @@ -73,7 +76,11 @@ export default function SourceGrid(p: { activeTab: string; searchTerm: string })
const iterableWidgetTypesBase = useMemo(() => {
// TODO: this can be combined and the conditions improved to make it more performant and readable
const filtered = Object.keys(WidgetType)
.filter((type: string) => isNaN(Number(type)) && type !== 'SubscriberGoal')
.filter(
(type: string) =>
isNaN(Number(type)) &&
!DEPRECATED_WIDGETS.includes(WidgetType[type as keyof typeof WidgetType] as WidgetType),
)
.filter((type: string) => {
// @ts-ignore
const displayData = WidgetDisplayData(primaryPlatform)[WidgetType[type]];
Expand Down
Loading