Skip to content

Clear server/key when enabling/disabling protected mode #5827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mhoyer-streamlabs wants to merge 2 commits into
base: master
Choose a base branch
from
+5 −1
Open

Clear server/key when enabling/disabling protected mode #5827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6557d49
Clear key and server when enabling/disabling protected mode
mhoyer-streamlabs Apr 6, 2026
b046729
Test fix
mhoyer-streamlabs Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions app/components-react/windows/settings/Stream.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,8 @@ export function StreamSettings() {
function disableProtectedMode() {
StreamSettingsService.actions.setSettings({
protectedModeEnabled: false,
key: '',
server: '',
streamType: 'rtmp_common',
});

Expand All @@ -236,6 +238,7 @@ export function StreamSettings() {
StreamSettingsService.actions.setSettings({
protectedModeEnabled: true,
key: '',
server: '',
streamType: 'rtmp_custom',
});
}
Expand Down
3 changes: 2 additions & 1 deletion test/regular/settings/streaming.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@ test('Populates stream settings after go live', async t => {
t.pass();
});

test('Populates stream key after go live', async t => {
//Skipping this test because we now clear settings when switching between Recommended Settings and Custom Ingest
test.skip('Populates stream key after go live', async t => {
const user = await logIn(t);

// make sure all required fields are filled for platforms
Expand Down
Loading