fix out-of-bounds read in repe zero-copy read_params - #2729
Open
uwezkhan wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
registry::call(std::span<const char>, std::string&)parses the request in place, sostate.in.bodyviews the caller's span with nothing guaranteed after it, yet thestate_viewoverload ofread_paramsreads that view with the registry'sOpts, whosenull_terminatedis on by default. That is the mode in which the JSON reader drops its end checks and scans for a'\0'sentinel. Before: a 51 byte buffer holding a well formed message whose body is1gives an ASAN heap-buffer-overflow read of size 1, zero bytes past the allocation; after: the scan stops at the end of the span.The
messageoverload beside it is unaffected because its body is astd::string, which does supply that sentinel, so the view overload is where the buffer shape is known and where the bound belongs rather than in the callers that own the span. Reading the body as unterminated input trades the sentinel scan for per-byte end checks. It also moves one edge case: a whitespace-only body now reads as an empty value instead of a number failure, which is whatglz::readalready returns for the same bytes withnull_terminatedoff.