fix(repo): a scratch local-config copy reached a public repo; widen the pattern - #337
Merged
Merged
Conversation
…he pattern `delvewright.local.toml_test` — a scratch copy made while testing the refimg provider — was committed in #334 and is on public `main`. `.gitignore` matched only the exact name `delvewright.local.toml`, so any suffixed variant fell straight through. NO KEY LEAKED, and that is a property of the design rather than of luck: the file names an ENVIRONMENT VARIABLE (`api_key_env`), never a value, so the worst a committed copy can disclose is a variable name and an aspect ratio. History audited to confirm it, not assumed — this is the only matching path ever added (#334's branch commit and its squash), and no key-shaped literal appears in any .toml/.json/.py across the last 200 commits. The file is removed and the pattern widened to `delvewright.local.toml*`, so the next scratch copy is ignored instead of merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
delvewright.local.toml_test— a scratch copy made while testing the refimg provider — was committed in #334 and is on publicmain..gitignorematched only the exact name, so any suffixed variant fell through.No key leaked, by design rather than by luck. The local config names an environment variable (
api_key_env), never a value — so the worst a committed copy can disclose is a variable name, a model name and an aspect ratio. Audited rather than assumed: this is the only matching path ever added to the repo (#334's branch commit and its squash on main), and no key-shaped literal appears in any.toml/.json/.pyacross the last 200 commits.File removed; pattern widened to
delvewright.local.toml*so the next scratch copy is ignored instead of merged. Verified withgit check-ignoreon both the bare name and the suffixed one.