Skip to content

fix(emit): the delve's own machinery narrated itself to the player #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stellarfeline merged 2 commits into from
Aug 8, 2026
Merged

fix(emit): the delve's own machinery narrated itself to the player #332

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f25bd07
fix(emit): the delve's own machinery narrated itself to the player
stellarfeline Aug 8, 2026
56a5fbd
Merge branch 'main' into fix/command-feedback-leak
stellarfeline Aug 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions crates/compiler/src/emit.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1388,6 +1388,20 @@ fn sealing_commands(
// Box-garden death policy: dying must never cost quest items (a dropped
// trial key despawns in 5 minutes = softlock for a human player).
"gamerule keep_inventory true".to_string(),
// The delve's own machinery must not narrate itself. Dialogue options are
// `trigger`-type objectives (`dw.dlg_<npc>`, `dw.class`), so every option a
// player picks runs `/trigger` and vanilla answers it in chat — "Triggered
// [dw.dlg_antiphos]" beside the line the character just said (owner
// playtest, 2026-08-07). Command feedback is engine implementation reaching
// the player, which is what every other rule in this list exists to stop;
// it was simply missing from the seal. NOT version-gated: a campaign at any
// `dsl_version` wants its dialogue to stop announcing its scoreboard.
// rcon replies to the caller regardless of this rule, so the harness and
// `validation/` are unaffected, and the creator overlay's log stamp is
// `log_admin_commands`, a different rule. (The legacy camelCase spelling is
// rejected outright by 1.21.11 — the compiler's own command validator caught
// `sendCommandFeedback` here before it could reach a world.)
"gamerule send_command_feedback false".to_string(),
format!("time set {}", time.token()),
];
// Traps (DSL v0.6, spec-0011) exclude TNT as a payload — no gamerule separates
Expand Down
Loading