Repository navigation
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This was referenced Oct 26, 2026
tamirms
force-pushed
the
tamirms/sdk-single-pass-walk
branch
from
October 27, 2026 10:20
38638a2 to
1dd38f1
Compare
tamirms
force-pushed
the
tamirms/sdk-single-pass-walk
branch
from
October 27, 2026 11:16
1dd38f1 to
6c11c64
Compare
Pin go-stellar-sdk to stellar/go-stellar-sdk#6013. Its walk records where each product's fields sit, so the events and fee products read at those offsets instead of walking the meta again. Its event products return element views. The events shaping and the txhash read path take the views as they are, and ParseTransactionView turns them back into the byte slices store.Transaction holds, sharing the view's buffer. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tamirms
force-pushed
the
tamirms/sdk-single-pass-walk
branch
from
October 28, 2026 08:05
6c11c64 to
01da594
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Pins go-stellar-sdk to stellar/go-stellar-sdk#6013, "ingest: walk TxProcessing once and record where each product's fields sit", at 099e046f. Its walk records where each product's fields sit, so the events and fee products read at those offsets instead of walking each transaction's meta again.
Its event products return element views (
xdr.TransactionEventView,xdr.ContractEventViewandxdr.DiagnosticEventView). The events shaping and the tx-hash read path take the views as they are.ParseTransactionViewturns them back into the byte slicesstore.Transactionholds, sharing the view's buffer.This PR can merge only after stellar/go-stellar-sdk#6013 merges and the pin moves to the merged commit.
Tests:
TestCompactView_CopiesOutOfTheLedgerBuffernow builds its input from the view types. The touched packages' tests pass against the pinned SDK.Why
The hot loop's one
ExtractLedgerTxPartswalk feeds every product, but on the released SDK the events and fee products then walk each transaction's meta again to find their fields. At sac-9000 density that is the meta of 9,000 transactions per ledger, walked again.🤖 Generated with Claude Code