Skip to content

clients/horizonclient: reject conflicting claimable balance request filters - #6024

Open
zerozebrazone wants to merge 1 commit into
stellar:mainfrom
zerozebrazone:master
Open

zerozebrazone wants to merge 1 commit into
stellar:mainfrom
zerozebrazone:master

Conversation

@zerozebrazone

Copy link
Copy Markdown
PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've reviewed the changes in this PR and if I consider them worthwhile for being mentioned on release notes then I have updated the relevant CHANGELOG.md within the component folder structure. For example, if I changed horizon, then I updated (services/horizon/CHANGELOG.md. I add a new line item describing the change and reference to this PR. If I don't update a CHANGELOG, I acknowledge this PR's change may not be mentioned in future release notes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Reject operation and transaction requests that combine ForClaimableBalance with another resource filter.

Why

OperationRequest.BuildURL() and TransactionRequest.BuildURL() use ForClaimableBalance to construct the endpoint but did not include it in the mutually exclusive filter count. Conflicting filters could therefore silently override one another instead of returning invalid request: too many parameters.

This change includes ForClaimableBalance in both checks and adds regression coverage for conflicts with account, ledger, and liquidity pool filters.

Known limitations

N/A

…ilters

Signed-off-by: zerozebrazone <zerozebrazone@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant