Skip to content

fix(p2p): downgrade unlinkable block error to warning during sync #3711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ety001 merged 1 commit into from
May 24, 2026
+11 −1
Merged

fix(p2p): downgrade unlinkable block error to warning during sync #3711

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion libraries/plugins/p2p/p2p_plugin.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,17 @@ bool p2p_plugin_impl::handle_block( const graphene::net::block_message& blk_msg,

return result;
} catch ( const chain::unlinkable_block_exception& e ) {
// translate to a graphene::net exception
// During sync, receiving blocks from forks is expected behavior.
// Downgrade to warning to avoid log noise.
if ( sync_mode ) {
fc_wlog(fc::logger::get("sync"),
"Dropping unlinkable sync block #${block_num} (head is ${head}): ${e}",
("block_num", blk_msg.block.block_num())
("head", head_block_num)
("e", e.to_detail_string()));
return false;
}
// Non-sync: translate to a graphene::net exception to trigger sync restart
fc_elog(fc::logger::get("sync"),
"Error when pushing block, current head block is ${head}:\n${e}",
("e", e.to_detail_string())
Expand Down
Loading