Feat/branch state guard readers - #175
Merged
Merged
Conversation
Add public readers for the six state guard options so renderers don't need instance_variable_get. Guards are stored as frozen copies (branches are shared with subclasses) and must be a Hash; anything else raises ArgumentError at definition. README error handling section now reflects when errors are raised.
State guards called object.send(machine_name), which raised NoMethodError (or read an unrelated method) when the guarded machine used attribute:.
An empty guard Hash made if_any_state/unless_all_states block the transition forever while renderers drew it as unconditional.
Expose it as Branch#state_guards and stop allocating it on every guard check. Merge the identical unless_state/unless_any_state branches.
Transitions guarded by if_state and friends were printed as unconditional.
STDIORenderer took keyword args while callers and the graphviz/diagram/ mermaid renderers use positional (obj, graph, options, io), so Event#draw and State#draw raised ArgumentError. Branch#draw called an undefined machine method; resolve it through the event.
seuros
force-pushed
the
feat/branch-state-guard-readers
branch
from
September 25, 2026 22:12
37ba556 to
dda0646
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry picked bunch of correctness fixes i had locally .
None should break existing applications , however if the application were doing illegal transaction , the errors will surface.
release-as: 0.300.0