Repository navigation
chore(discovery-service): adjust default config - #585
Merged
Merged
Conversation
This was referenced Feb 26, 2026
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
m-kus
marked this pull request as ready for review
February 26, 2026 18:06
m-kus
force-pushed
the
02-26-chore_discovery-service_adjust_default_config
branch
2 times, most recently
from
February 26, 2026 19:30
a105ec3 to
44f48e2
Compare
Yoni-Starkware
approved these changes
Mar 1, 2026
Yoni-Starkware
left a comment
Yoni-Starkware
left a comment
Collaborator
There was a problem hiding this comment.
@Yoni-Starkware reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on m-kus).
m-kus
force-pushed
the
02-25-feat_discovery-service_validate_viewing_key
branch
from
March 1, 2026 17:28
836d736 to
f8bbaa8
Compare
m-kus
force-pushed
the
02-26-chore_discovery-service_adjust_default_config
branch
2 times, most recently
from
March 2, 2026 09:47
5030cc7 to
60694d6
Compare
m-kus
force-pushed
the
02-25-feat_discovery-service_validate_viewing_key
branch
from
March 2, 2026 09:47
f8bbaa8 to
269ef9f
Compare
Yoni-Starkware
approved these changes
Mar 2, 2026
Yoni-Starkware
left a comment
Yoni-Starkware
left a comment
Collaborator
There was a problem hiding this comment.
@Yoni-Starkware reviewed 2 files and all commit messages.
Reviewable status:
m-kus
force-pushed
the
02-25-feat_discovery-service_validate_viewing_key
branch
from
March 2, 2026 15:38
269ef9f to
8d4649f
Compare
m-kus
force-pushed
the
02-26-chore_discovery-service_adjust_default_config
branch
from
March 2, 2026 15:38
60694d6 to
b44d88c
Compare
m-kus
changed the base branch from
02-25-feat_discovery-service_validate_viewing_key
to
graphite-base/585
March 2, 2026 15:39
m-kus
force-pushed
the
02-26-chore_discovery-service_adjust_default_config
branch
from
March 2, 2026 15:52
b44d88c to
9725d83
Compare
m-kus
force-pushed
the
02-26-chore_discovery-service_adjust_default_config
branch
from
March 2, 2026 15:54
9725d83 to
c501ee3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Increased server budget and RPC batch size limits in the discovery service configuration.
What changed?
server_budgetfrom 100/200 to 10,000 in both the default configuration and documentationmax_batch_sizefrom 50 to 100 in the default configurationSERVER_BUDGETenvironment variable default valueWhy make this change?
These limit increases allow the discovery service to handle higher throughput scenarios by processing larger batches and supporting more concurrent operations within the server budget constraints.
This change is