apollo_config,apollo_node_config,apollo_deployments,deployment: jsonnet-native node config

[itamar-starkware]

No description provided.

[cursor]

PR Summary

Medium Risk
This changes how every node loads and merges configuration at startup; mistakes in file layout, secret keys, or Jsonnet output could misconfigure or partially apply secrets across many components.

Overview
Moves node configuration off the old flattened dump / SerializeConfig / per-flag CLI model to nested JSON configs plus flat dotted-key secret overlays, aligned with Jsonnet-generated deployments.

apollo_config drops dumping (pointers, #is_none flags, ser_param, generated defaults in dumps). Startup CLI now only accepts --config_file (repeatable); values come from files, not env/CLI per path. Loading expects two config files: nested base, then secrets merged by dotted paths (skips overrides under null optionals; can add missing leaves when the parent exists). Config presentation/redaction takes an explicit private path set instead of metadata baked into dumps. Duration fields gain matching serialize_with helpers for round-trip JSON.

Component config crates shed SerializeConfig impls and often drop unused apollo_config deps; a few comments/docs note fields mirrored or validated at the node level (e.g. validation_only).

apollo_deployments evaluates Jsonnet via jrsonnet-evaluator / jrsonnet-stdlib (replacing prior compile-time config machinery in that crate). Workspace Cargo.lock picks up jrsonnet and routine transitive bumps.

CI: hybrid CDK8s synth no longer passes the hybrid.common.dummy_for_testing overlay.

^{Reviewed by Cursor Bugbot for commit dfa82ea. Bugbot is set up for automated code reviews on this repo. Configure here.}

[reviewable-StarkWare]

This change is 

[github-actions]

Artifacts upload workflows:

• Started at 2026-09-03T13:44:37Z
• Started at 2026-09-03T16:14:21Z

[itamar-starkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• apollo_config,apollo_node_config,apollo_deployments,deployment: jsonnet-native node config #15096 👈 (View in Graphite)
• ci: pin remaining GitHub Actions to commit SHAs #15097
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[cursor]

Test clears validation only flag

Low Severity

validation_only_with_tx_ingestion_disabled_succeeds sets validation_only: true, then calls normalize_pointer_groups, which forces the node-level and batcher validation_only fields to false. The test therefore never runs validate_validation_only_config in the mode it claims to cover, so regressions in validation-only boot checks could pass CI unnoticed.

 

^{Reviewed by Cursor Bugbot for commit 068fbf9. Configure here.}

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit dfa82ea. Configure here.}

[cursor]

Modified configs fail secret reload

High Severity

modify_config rewrites only the nested base file. Custom Sensitive deserializers such as deserialize_optional_sensitive_map accept a string, but serde emits null for None. After a later change that introduces a new secret field (for example enabling central_sync_client_config), the stale secrets overlay has no override and native load fails.

Additional Locations (2)

• crates/apollo_node_config/src/config_utils.rs#L47-L50
• crates/apollo_config/src/converters.rs#L104-L125

 

^{Reviewed by Cursor Bugbot for commit dfa82ea. Configure here.}