apollo_deployments: load each service's app configs through the node entry point - #15085
apollo_deployments: load each service's app configs through the node entry point#15085matanl-starkware wants to merge 1 commit into
Conversation
PR SummaryLow Risk Overview Before loading,
Reviewed by Cursor Bugbot for commit c2665f3. Bugbot is set up for automated code reviews on this repo. Configure here. |
…entry point Runs every layout/service through `SequencerNodeConfig::load_and_process`, the same call a pod makes, with deploy-time values stubbed: a replacer placeholder takes the schema default, and the six pointer targets take a well-formed dummy. Catches stale params, wrong value types and pruning errors, none of which the coverage test sees. No apollo_config visibility changes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
8e36716 to
c2665f3
Compare
Addresses yoavGrs' line-132 comment on #15083. Stacked on it — rebase onto main-v0.14.4 once that merges.
Making the merge helper pub is the wrong route:
update_config_maptype-checks, and 116 app-config values are$$$_…_$$$placeholders that fail it. Stub those first and the whole production entry point works instead —SequencerNodeConfig::load_and_process, the same call a pod makes, no visibility changes.Catches stale params, wrong types and pruning errors.