Skip to content

apollo_deployments: load each service's app configs through the node entry point - #15085

Open
matanl-starkware wants to merge 1 commit into
main-v0.14.4from
matanl/load-service-configs-test
Open

apollo_deployments: load each service's app configs through the node entry point#15085
matanl-starkware wants to merge 1 commit into
main-v0.14.4from
matanl/load-service-configs-test

Conversation

@matanl-starkware

@matanl-starkware matanl-starkware commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Addresses yoavGrs' line-132 comment on #15083. Stacked on it — rebase onto main-v0.14.4 once that merges.

Making the merge helper pub is the wrong route: update_config_map type-checks, and 116 app-config values are $$$_…_$$$ placeholders that fail it. Stub those first and the whole production entry point works instead — SequencerNodeConfig::load_and_process, the same call a pod makes, no visibility changes.

Catches stale params, wrong types and pruning errors.

@cursor

cursor Bot commented Sep 1, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Test-only changes plus a small refactor to share replacer placeholder formatting; no production deployment or runtime behavior changes.

Overview
Adds all_service_configs_load, which exercises every node service’s merged application configs through SequencerNodeConfig::load_and_process—the same path pods use at startup—plus a default secrets file.

Before loading, deploy_time_value substitutes environment-specific values: $$$_…_$$$ replacer placeholders become schema defaults, and PointerTarget entries become small well-formed stubs (e.g. SN_MAIN, localhost URLs, 0x1 addresses).

replacers.rs exposes the placeholder string logic as replacer_annotation so tests and replacer generation share one definition instead of a private format_key.

Reviewed by Cursor Bugbot for commit c2665f3. Bugbot is set up for automated code reviews on this repo. Configure here.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

@matanl-starkware
matanl-starkware changed the base branch from matanl/deployment-config-schema-coverage-test to main-v0.14.4 September 1, 2026 16:09
…entry point

Runs every layout/service through `SequencerNodeConfig::load_and_process`, the same
call a pod makes, with deploy-time values stubbed: a replacer placeholder takes the
schema default, and the six pointer targets take a well-formed dummy. Catches stale
params, wrong value types and pruning errors, none of which the coverage test sees.
No apollo_config visibility changes.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@matanl-starkware
matanl-starkware force-pushed the matanl/load-service-configs-test branch from 8e36716 to c2665f3 Compare September 1, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants