Skip to content

starknet_os: preallocate CompressionSet vectors to avoid reallocation #15003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gkaempfer wants to merge 2 commits into
base: main
Choose a base branch
from
Open

starknet_os: preallocate CompressionSet vectors to avoid reallocation #15003

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f81708a
starknet_os: preallocate decompress result vectors to avoid reallocation
claude Jul 13, 2026
5a9a419
starknet_os: preallocate CompressionSet vectors to avoid reallocation
claude Aug 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions crates/starknet_os/src/hints/hint_implementation/stateless_compression/utils.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,8 +360,8 @@ impl CompressionSet {
pub fn new(values: &[Felt]) -> Self {
let mut obj = Self {
unique_value_buckets: Buckets::new(),
repeating_value_bucket: Vec::new(),
bucket_index_per_elm: Vec::new(),
repeating_value_bucket: Vec::with_capacity(values.len()),
bucket_index_per_elm: Vec::with_capacity(values.len()),
};
let repeating_values_bucket_index = N_UNIQUE_BUCKETS;

Expand Down Expand Up @@ -575,7 +575,7 @@ pub fn decompress(compressed: &mut impl Iterator<Item = Felt>) -> Vec<Felt> {
let unique_value_bucket_lengths: Vec<usize> = header[2..2 + N_UNIQUE_BUCKETS].to_vec();
let n_repeating_values = &header[2 + N_UNIQUE_BUCKETS];

let mut unique_values = Vec::new();
let mut unique_values = Vec::with_capacity(unique_value_bucket_lengths.iter().sum());
unique_values.extend(compressed.take(unique_value_bucket_lengths[0])); // 252 bucket.
unique_values.extend(unpack_chunk::<125>(compressed, unique_value_bucket_lengths[1]));
unique_values.extend(unpack_chunk::<83>(compressed, unique_value_bucket_lengths[2]));
Expand Down Expand Up @@ -605,7 +605,7 @@ pub fn decompress(compressed: &mut impl Iterator<Item = Felt>) -> Vec<Felt> {

let mut bucket_offset_trackers: Vec<_> = bucket_offsets;

let mut result = Vec::new();
let mut result = Vec::with_capacity(*data_len);
for bucket_index in bucket_index_per_elm {
let offset = &mut bucket_offset_trackers[bucket_index];
let value = all_values[*offset];
Expand Down
Loading