Skip to content

starknet_transaction_prover: log resolved config at startup (secrets redacted) - #14684

Open
avi-starkware wants to merge 2 commits into
avi/prover-v3/error-origin-logsfrom
avi/prover-v3/startup-config-log
Open

starknet_transaction_prover: log resolved config at startup (secrets redacted)#14684
avi-starkware wants to merge 2 commits into
avi/prover-v3/error-origin-logsfrom
avi/prover-v3/startup-config-log

Conversation

@avi-starkware

Copy link
Copy Markdown
Collaborator

No description provided.

avi-starkware commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator Author

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

@avi-starkware
avi-starkware force-pushed the avi/prover-v3/startup-config-log branch from 4dbaf70 to b7a5530 Compare July 2, 2026 09:53
@avi-starkware
avi-starkware force-pushed the avi/prover-v3/startup-config-log branch 2 times, most recently from 1d77aa9 to c05ad80 Compare July 8, 2026 10:52
@avi-starkware
avi-starkware force-pushed the avi/prover-v3/docs branch 2 times, most recently from bcbb997 to c8cd445 Compare July 9, 2026 08:08
@avi-starkware
avi-starkware force-pushed the avi/prover-v3/startup-config-log branch from c05ad80 to 2d527fb Compare July 9, 2026 08:08
@avi-starkware
avi-starkware force-pushed the avi/prover-v3/startup-config-log branch from 2d527fb to 61786ad Compare July 9, 2026 11:39
@avi-starkware
avi-starkware force-pushed the avi/prover-v3/startup-config-log branch 2 times, most recently from 966a84b to 9613ecb Compare July 12, 2026 12:39
@avi-starkware
avi-starkware force-pushed the avi/prover-v3/startup-config-log branch from 9613ecb to ae5115b Compare July 13, 2026 11:45
@avi-starkware
avi-starkware force-pushed the avi/prover-v3/docs branch 2 times, most recently from 4039e1e to f920731 Compare July 19, 2026 12:24
@avi-starkware
avi-starkware force-pushed the avi/prover-v3/startup-config-log branch from af7273c to 1c9e648 Compare August 25, 2026 08:23
@avi-starkware
avi-starkware changed the base branch from graphite-base/14684 to avi/prover-v3/error-origin-logs August 25, 2026 08:24
@avi-starkware
avi-starkware force-pushed the avi/prover-v3/error-origin-logs branch from 32a07a2 to be0a076 Compare August 25, 2026 10:14
@avi-starkware
avi-starkware force-pushed the avi/prover-v3/startup-config-log branch from 1c9e648 to 8ccf362 Compare August 25, 2026 10:14
@avi-starkware
avi-starkware marked this pull request as ready for review August 25, 2026 10:57
@cursor

cursor Bot commented Aug 25, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Observability-only change with explicit URL redaction and a regression test; no request-handling or auth behavior changes.

Overview
Startup configuration logging moves from an inline banner in main to ServiceConfig::log_startup_summary(), which emits a structured event="config_resolved" line after file/env/CLI merge and before the server binds.

That log records build identity plus the resolved service and prover settings operators care about (listen address, transport, queue/connection limits, CORS, OHTTP, chain/RPC/blocking-check options, etc.), while RPC and blocking-check URLs stay host-only and TLS cert/key paths are omitted. The post-bind “server is running” log is unchanged; the README now documents the two startup lines and updates redaction wording.

A traced_test asserts URL userinfo and path secrets never appear in the startup summary output.

Reviewed by Cursor Bugbot for commit adbd7ea. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8ccf362. Configure here.

for secret in ["sekret", "hunter2", "api-key"] {
assert!(!logs_contain(secret), "`{secret}` from a URL must never reach the log stream");
}
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weak startup redaction test isolation

Low Severity

startup_summary_logs_hosts_and_redacts_url_credentials calls from_args before log_startup_summary, and from_args already emits redacted CLI-override lines that include the same hosts. The positive logs_contain host checks can therefore pass even if log_startup_summary stops logging hosts. Secret-absence checks still cover the summary path, but host logging on the config_resolved line is not actually pinned.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 8ccf362. Configure here.

@avi-starkware
avi-starkware force-pushed the avi/prover-v3/startup-config-log branch from 8ccf362 to e8ff70d Compare August 25, 2026 19:09
@avi-starkware
avi-starkware force-pushed the avi/prover-v3/error-origin-logs branch from be0a076 to b3b4624 Compare August 25, 2026 19:09
@github-actions github-actions Bot removed the stale label Aug 26, 2026
@avi-starkware
avi-starkware force-pushed the avi/prover-v3/error-origin-logs branch from b3b4624 to b5817a7 Compare August 26, 2026 09:54
@avi-starkware
avi-starkware force-pushed the avi/prover-v3/startup-config-log branch 2 times, most recently from 3ea01fa to 584ce7f Compare August 26, 2026 13:15
@avi-starkware
avi-starkware force-pushed the avi/prover-v3/error-origin-logs branch from b5817a7 to 4dcf6e3 Compare August 26, 2026 13:15
@avi-starkware
avi-starkware force-pushed the avi/prover-v3/startup-config-log branch from 584ce7f to f9c20b7 Compare August 26, 2026 13:39
@avi-starkware
avi-starkware force-pushed the avi/prover-v3/error-origin-logs branch 2 times, most recently from c33d7b5 to cc44d74 Compare August 26, 2026 14:04
@avi-starkware
avi-starkware force-pushed the avi/prover-v3/startup-config-log branch from f9c20b7 to 2154484 Compare August 26, 2026 14:04
avi-starkware and others added 2 commits August 26, 2026 18:37
…d-config log

The banner and `config_resolved` were adjacent startup `info!`s sharing six
fields; version and git SHA move into `log_startup_summary` and the banner is
deleted, leaving one startup event. Adds the test this PR was missing: it feeds
credential-bearing URLs and asserts the hosts are logged while the password and
API-key path segment are not.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants