starknet_transaction_prover: log resolved config at startup (secrets redacted) - #14684
starknet_transaction_prover: log resolved config at startup (secrets redacted)#14684avi-starkware wants to merge 2 commits into
Conversation
9963124 to
d849e1a
Compare
4dbaf70 to
b7a5530
Compare
d849e1a to
93deeae
Compare
1d77aa9 to
c05ad80
Compare
bcbb997 to
c8cd445
Compare
c05ad80 to
2d527fb
Compare
c8cd445 to
87bc833
Compare
2d527fb to
61786ad
Compare
87bc833 to
c1354ec
Compare
966a84b to
9613ecb
Compare
c1354ec to
60faf0c
Compare
9613ecb to
ae5115b
Compare
4039e1e to
f920731
Compare
8a451d7 to
32a07a2
Compare
af7273c to
1c9e648
Compare
32a07a2 to
be0a076
Compare
1c9e648 to
8ccf362
Compare
PR SummaryLow Risk Overview That log records build identity plus the resolved service and prover settings operators care about (listen address, transport, queue/connection limits, CORS, OHTTP, chain/RPC/blocking-check options, etc.), while RPC and blocking-check URLs stay host-only and TLS cert/key paths are omitted. The post-bind “server is running” log is unchanged; the README now documents the two startup lines and updates redaction wording. A Reviewed by Cursor Bugbot for commit adbd7ea. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8ccf362. Configure here.
| for secret in ["sekret", "hunter2", "api-key"] { | ||
| assert!(!logs_contain(secret), "`{secret}` from a URL must never reach the log stream"); | ||
| } | ||
| } |
There was a problem hiding this comment.
Weak startup redaction test isolation
Low Severity
startup_summary_logs_hosts_and_redacts_url_credentials calls from_args before log_startup_summary, and from_args already emits redacted CLI-override lines that include the same hosts. The positive logs_contain host checks can therefore pass even if log_startup_summary stops logging hosts. Secret-absence checks still cover the summary path, but host logging on the config_resolved line is not actually pinned.
Reviewed by Cursor Bugbot for commit 8ccf362. Configure here.
8ccf362 to
e8ff70d
Compare
be0a076 to
b3b4624
Compare
b3b4624 to
b5817a7
Compare
3ea01fa to
584ce7f
Compare
b5817a7 to
4dcf6e3
Compare
584ce7f to
f9c20b7
Compare
c33d7b5 to
cc44d74
Compare
f9c20b7 to
2154484
Compare
…d-config log The banner and `config_resolved` were adjacent startup `info!`s sharing six fields; version and git SHA move into `log_startup_summary` and the banner is deleted, leaving one startup event. Adds the test this PR was missing: it feeds credential-bearing URLs and asserts the hosts are logged while the password and API-key path segment are not. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2154484 to
b038cd5
Compare
cc44d74 to
3b88f89
Compare
3b88f89 to
f9f5e5d
Compare
b038cd5 to
adbd7ea
Compare



No description provided.