Single writer/multiple reader MMR store - #376
Merged
Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
m-kus
marked this pull request as ready for review
September 29, 2025 18:22
m-kus
force-pushed
the
09-29-single_writer_multiple_reader_mmr_store
branch
from
September 29, 2025 18:34
d3336ab to
a621be0
Compare
Collaborator
|
Does it make sense to use sqllite if it require maintaining extra logic to manage connections? Wouldn't a good old postgres be a better choice? |
maciejka
approved these changes
Sep 29, 2025
Member
Author
|
External PG seems like an overkill, embedded db is a simpler option. We do need acid transaction though (to avoid weird indexing issues), so sqlite is a good choice. |
Merged
m-kus
force-pushed
the
09-29-single_writer_multiple_reader_mmr_store
branch
2 times, most recently
from
October 3, 2025 16:16
fdd9498 to
5ffb65f
Compare
m-kus
force-pushed
the
m-kus/index-chain-state
branch
from
October 3, 2025 16:19
4365521 to
69221cc
Compare
m-kus
force-pushed
the
09-29-single_writer_multiple_reader_mmr_store
branch
from
October 3, 2025 16:19
5ffb65f to
e967826
Compare
Merged
m-kus
force-pushed
the
09-29-single_writer_multiple_reader_mmr_store
branch
from
October 6, 2025 13:27
e967826 to
f8254bd
Compare
m-kus
force-pushed
the
m-kus/index-chain-state
branch
from
October 6, 2025 13:27
69221cc to
295b2ac
Compare
m-kus
force-pushed
the
09-29-single_writer_multiple_reader_mmr_store
branch
from
October 6, 2025 20:37
f8254bd to
f87e158
Compare
m-kus
added a commit
that referenced
this pull request
Oct 8, 2025
maciejka
pushed a commit
that referenced
this pull request
Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR replaces the SQLite store backend from rust-accumulators with a new one, more configurable. The implementation:
MMRStorethat implements theBlockMMRStoretrait with SQLite backendBlockMMRto use the new storage interfaceThe PR also adds the
async-traitdependency and integrates theaccumulatorscrate from the workspace dependencies.