lab: wfbench — validation as judge evidence, namespace as run input - #1653
Merged
Conversation
- wfbench-run runs meta/validate-workflow on the produced YAML and hands the result to build-materials as a VALIDATION material (ok / errors / warnings / summary) — evidence for structural criteria, never a gate. - input.namespace overrides params.namespace for every roster/record write, so Hive can pass the partition its own roster upsert used and vein's EvalSet/EvalRequirement writes merge onto its nodes by id instead of creating a second roster.
Collaborator
Author
|
Live run 1788554443025 on this branch with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small pieces toward the Hive "run in vein" toggle.
wfbench-runnow runsmeta/validate-workflowon the produced YAML andwfbench/build-materialsinlines the result as aVALIDATIONmaterial (ok,errors,warnings,summary). Structural criteria ("workflow is structurally valid") get judged on the engine's own check plus the rerun status instead of on the judge's reading of the YAML. Not a gate: a candidate that validates poorly is still launched and judged.input.namespace || params.namespaceon every roster/record write. Hive already upserts the EvalSet/EvalRequirement roster through jarvis before dispatch; passing that partition lets vein's writes merge onto the same nodes by id rather than creating a second roster underwfbench.Verification: mcp
tscclean;npx tsx src/lab/wfbench/smoke.tsgreen (both workflows static-validate, build-materials asserts the VALIDATION section).