lab: seeders retire steps they no longer ship - #1652
Merged
Conversation
Seeding is additive: a step dropped from a SEED_STEPS list stayed live in every existing workspace (the graph one is persistent), so the wfbench author kept finding and using gaia/pack-result after it was deleted from the repo. Each seeder now carries a RETIRED_STEPS list and calls retireSteps (seed-opts.ts) after seeding — workspace.deleteStep per type, a soft delete on the graph store, silent when absent. harvey retires its four moved/removed steps, gaia and wfbench their pack-result copies. The wfbench smoke publishes a stale copy first and asserts reseeding removes it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seeding is additive: dropping a step from a seeder's
SEED_STEPSnever removed it from an existing workspace, and the lab's workspace is graph-backed and persistent. That's how the wfbench author kept pickinggaia/pack-resulttwo runs after #1651 deleted it from the repo — the type was still discoverable and still loaded.retireSteps(workspace, types, tag)inseed-opts.ts:workspace.deleteStepper type (soft delete on the graph store, unlink on the file store), logs only when something was actually retired, silent on a fresh workspace.RETIRED_STEPSlists: harvey (pack-result,aggregate-scores,build-eval-chain,criterion-refs— the four moved in vein: meta/validate-workflow; lab: promote eval scoring steps to eval/* #1648/lab: wfbench — Workflow Editor Agent Benchmark harness + core pack step (re-land on main) #1651), gaia and wfbench (pack-result). Each seeder calls it after seeding its steps.wfbench/pack-resultfirst and asserts reseeding retires it.Verified: mcp
tscclean; smokes green (wfbench, harvey deliver, gaia, gaia evolve, harvey evolve — the last one runs against the real local graph workspace and retired the three stale harvey types there).