Conversation
|
@rasheedamir PR doc deploy will soon be available for review on https://stakater.github.io/mto-docs/argocd-extension |
|
@rasheedamir Image is available for testing. |
|
@rasheedamir PR doc deploy will soon be available for review on https://stakater.github.io/mto-docs/argocd-extension |
|
@rasheedamir Image is available for testing. |
| namespace: mto-system | ||
| spec: | ||
| # Global on/off for this extension instance. | ||
| enabled: true |
There was a problem hiding this comment.
Its better to delete / comment out the Extension itself rather than disabling it through the controller. Unless we just want to disable the ingress or something instead?
There was a problem hiding this comment.
I was confused about this as well but GPT kept suggesting that I should have it! but its good you don't see its necessary like me
There was a problem hiding this comment.
so, the verdict is we remove it?
| # We DO NOT rely on namespace name prefixes/postfixes, and we DO NOT require Tenant.status. | ||
| # Instead we select namespaces by labels (Kubernetes-native + stable). | ||
| destinations: | ||
| strategy: NamespaceLabelSelector |
There was a problem hiding this comment.
This is also redundant. There's only 1 strategy. If needed, we can expand and add more keys instead of a 2 layered approach for filtering
There was a problem hiding this comment.
we can read namespaces from tenant.status as well but maybe that is not a good strategy at all
| # argocd.ext.mto.stakater.com/bootstrap-path: tenants/acme | ||
| # argocd.ext.mto.stakater.com/bootstrap-revision: main | ||
| repoURL: | ||
| defaultTemplate: "https://github.com/{{ .tenant.name }}/gitops" |
There was a problem hiding this comment.
This can be set to just template as we don't allow overriding it
There was a problem hiding this comment.
how do you mean exactly?
|
@rasheedamir PR doc deploy will soon be available for review on https://stakater.github.io/mto-docs/argocd-extension |
|
@rasheedamir Image is available for testing. |
|
@rasheedamir PR doc deploy will soon be available for review on https://stakater.github.io/mto-docs/argocd-extension |
|
@rasheedamir Image is available for testing. |
|
@rasheedamir PR doc deploy will soon be available for review on https://stakater.github.io/mto-docs/argocd-extension |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
@rasheedamir Image is available for testing. |
3 participants
first commit