Skip to content

Oauth fixes - #359

Open
jasonyess wants to merge 1 commit into
stadust:masterfrom
jasonyess:oauth-fix
Open

Oauth fixes#359
jasonyess wants to merge 1 commit into
stadust:masterfrom
jasonyess:oauth-fix

Conversation

@jasonyess

Copy link
Copy Markdown
Contributor

Right now the oauth is kinda unreliable

  • removed duplicate GSI (google sign in) scripts
  • Swapping async for defer in the GSI script definitions seemed to make it more consistent but i dont really know why :p (only reason i had it async in the localization impl was because the code snippet i referenced had it async)

License Acceptance

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov

codecov Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 35.79%. Comparing base (3734d28) to head (caef7b5).

Files with missing lines Patch % Lines
pointercrate-user-pages/src/login.rs 0.00% 3 Missing ⚠️
pointercrate-user-pages/src/register.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #359      +/-   ##
==========================================
+ Coverage   35.71%   35.79%   +0.07%     
==========================================
  Files         121      121              
  Lines        5886     5873      -13     
==========================================
  Hits         2102     2102              
+ Misses       3784     3771      -13     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant