Skip to content

added option to handle show or hide checkOptions under link popup #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
umarjavedse wants to merge 5 commits into
base: master
Choose a base branch
from
Open

added option to handle show or hide checkOptions under link popup #395

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
20f6730
added option to handle show or hide checkOptions under link popup
umar-evva Nov 25, 2020
e8fe570
replaced showCheckOptions with hideCheckOptions
umarjavedse Nov 25, 2020
5736bc0
Merge branch 'master' into master
umarjavedse Jul 1, 2021
21bdd6e
Merge branch 'master' into master
sstur Jan 28, 2022
35a8297
Merge branch 'sstur:master' into master
umarjavedse Feb 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/lib/EditorToolbar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,7 @@ export default class EditorToolbar extends Component {
let removeLinkConfig = config.removeLink || {};
let linkLabel = linkConfig.label || 'Link';
let removeLinkLabel = removeLinkConfig.label || 'Remove Link';
let linkHideCheckOptions = linkConfig.hideCheckOptions || false;
let targetBlank = (entity && isCursorOnLink) ? entity.getData().target === '_blank' : false;
let noFollow = (entity && isCursorOnLink) ? entity.getData().rel === 'nofollow' : false;

Expand All @@ -245,7 +246,7 @@ export default class EditorToolbar extends Component {
onTogglePopover={this._toggleShowLinkInput}
defaultValue={defaultValue}
onSubmit={this._setLink}
checkOptions={{
checkOptions={!linkHideCheckOptions && {
targetBlank: {label: 'Open link in new tab', defaultValue: targetBlank},
noFollow: {label: 'No follow', defaultValue: noFollow},
}}
Expand Down