HttpLoggingInterceptor: Recognize "br" (Brotli) as a known encoding#9420
Open
krahulshharmaa wants to merge 1 commit intosquare:masterfrom
Open
HttpLoggingInterceptor: Recognize "br" (Brotli) as a known encoding#9420krahulshharmaa wants to merge 1 commit intosquare:masterfrom
krahulshharmaa wants to merge 1 commit intosquare:masterfrom
Conversation
content encoding and skipped logging the response body by emitting:
"<-- END HTTP (encoded body omitted)".
OkHttp supports Brotli via the optional BrotliInterceptor and includes
"br" in accepted encodings. Treating it as unknown is therefore inconsistent.
This change updates the interceptor to recognize "br" as a known encoding,
allowing it to follow the normal logging flow (similar to "gzip").
Note:
This change does not add Brotli decompression. If BrotliInterceptor is
not used, the response body may still be logged as binary.
Tests are updated to use a truly unknown encoding ("xyz") to preserve
the original intent of verifying unknown encoding handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, HttpLoggingInterceptor treated "br" (Brotli) as an unknown
content encoding and skipped logging the response body by emitting:
"<-- END HTTP (encoded body omitted)".
OkHttp supports Brotli via the optional BrotliInterceptor and includes
"br" in accepted encodings. Treating it as unknown is therefore inconsistent.
This change updates the interceptor to recognize "br" as a known encoding,
allowing it to follow the normal logging flow (similar to "gzip").
Note:
This change does not add Brotli decompression. If BrotliInterceptor is
not used, the response body may still be logged as binary.
Tests are updated to use a truly unknown encoding ("xyz") to preserve
the original intent of verifying unknown encoding handling.