Make interactive mode the default - #1210
Closed
therepanic wants to merge 1 commit into
Closed
therepanic wants to merge 1 commit into
therepanic wants to merge 1 commit into
Conversation
Closes: spring-projectsgh-1186 Signed-off-by: Andrey Litvitski <andrey1010102008@gmail.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current commit, I'm changing the runner creation rules in the autoconfiguration module. Now, if the user doesn't specify a specific runner, we create a bean with
InteractiveShellRunner.I also rewrote the configuration test to accommodate our change.
Closes: gh-1186
Note: the build breaks not because of the current change, but because the previous commit in the repository breaks the build.