Detect annotations on @Bean methods when using @ServiceConnection#50033
Open
kwondh5217 wants to merge 1 commit intospring-projects:mainfrom
Open
Detect annotations on @Bean methods when using @ServiceConnection#50033kwondh5217 wants to merge 1 commit intospring-projects:mainfrom
kwondh5217 wants to merge 1 commit intospring-projects:mainfrom
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
…tionRegistrar Signed-off-by: Daeho Kwon <trewq231@naver.com>
kwondh5217
force-pushed
the
fix/50011-service-connection-bean-method-annotations
branch
from
e9e911c to
fd684d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, annotations such as
@Sslplaced on@Beanmethods were notdetected when using
@ServiceConnection, becauseServiceConnectionAutoConfigurationRegistraronly read annotations fromTestcontainerBeanDefinitioninstances and passed null for regular@Beanmethod beans.
This commit fixes the issue by reading annotations from the resolved
factory method of the
RootBeanDefinitionwhen the bean is not aTestcontainerBeanDefinition.Closes gh-50011