Fix resolvo build-env option propagation#1365
Open
jrray wants to merge 1 commit into
Open
Conversation
Add a cross-solver regression test for build-environment var options in Solution. The new test uses a simple recipe with my_var/true and asserts both solver flavors populate the option. Resolvo only collected options from solved packages and global-var solvables, which missed top-level var requests produced by configure_for_build_environment. Seed solution options from those requests before processing solved records to match step behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: J Robert Ray <jrray@imageworks.com>
dcookspi
approved these changes
May 15, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a cross-solver regression test for build-environment var options in Solution. The new test uses a simple recipe with my_var/true and asserts both solver flavors populate the option.
Resolvo only collected options from solved packages and global-var solvables, which missed top-level var requests produced by configure_for_build_environment. Seed solution options from those requests before processing solved records to match step behavior.