Indexes 7: Adds a lock file around index generation and updates#1354
Merged
Conversation
dcookspi
added
enhancement
dcookspi
force-pushed
the
index-7-lockfile-for-indexgen
branch
from
a0324cf to
85050e7
Compare
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This was referenced Apr 17, 2026
dcookspi
force-pushed
the
index-5-zplus-1-versionfilters-not-strings
branch
from
81fb685 to
f31a655
Compare
dcookspi
force-pushed
the
index-7-lockfile-for-indexgen
branch
from
85050e7 to
d4d81db
Compare
dcookspi
force-pushed
the
index-5-zplus-1-versionfilters-not-strings
branch
from
f31a655 to
d9f7cef
Compare
dcookspi
force-pushed
the
index-7-lockfile-for-indexgen
branch
from
d4d81db to
cddd514
Compare
dcookspi
force-pushed
the
index-5-zplus-1-versionfilters-not-strings
branch
from
d9f7cef to
7aa00a9
Compare
dcookspi
force-pushed
the
index-7-lockfile-for-indexgen
branch
from
cddd514 to
5ac3a7b
Compare
jrray
requested changes
May 6, 2026
jrray
requested changes
May 11, 2026
Comment on lines
+153
to
+156
| // Need to keep these if-statements separate | ||
| // to allow for two different error handling cases. | ||
| #[allow(clippy::collapsible_if)] | ||
| if let Some(err) = result.err() { |
Collaborator
There was a problem hiding this comment.
Suggested change
| // Need to keep these if-statements separate | |
| // to allow for two different error handling cases. | |
| #[allow(clippy::collapsible_if)] | |
| if let Some(err) = result.err() { | |
| if let Some(err) = result.err() { |
This can be removed, it was the unnecessary outer if causing the lint.
Collaborator
Author
There was a problem hiding this comment.
I've removed that now.
|
|
||
| /// Unlock this file lock by removing the lock file | ||
| /// | ||
| /// # Safety: |
Collaborator
There was a problem hiding this comment.
Suggested change
| /// # Safety: | |
| /// # Safety |
Collaborator
Author
There was a problem hiding this comment.
I've updated this.
Collaborator
|
Is it intentional that this PR has index-5 as the merge target and not index-6? |
Collaborator
Author
It has |
jrray
approved these changes
May 14, 2026
dcookspi
force-pushed
the
index-5-zplus-1-versionfilters-not-strings
branch
from
424f49a to
3b3ed45
Compare
Base automatically changed from
index-5-zplus-1-versionfilters-not-strings
to
main
May 14, 2026 21:59
Signed-off-by: David Gilligan-Cook <dcook@imageworks.com>
dcookspi
force-pushed
the
index-7-lockfile-for-indexgen
branch
from
501db10 to
d782c1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a lock file around index generation and update processing. The lock for the index file is created, via a
FileLockobject, before the underlying repo is read and kept until the index has been generated and written out. The same duration of locking is done for updating the index.A
FileLockhas configurable settings for the maximum number of tries to get the lock before giving up, and the amound of time to sleep between tries, as well as the kind of file being locked (used in log messages). It also contains sentry integration when the sentry feature is enabled.This is the 7th of the chained PRs for adding indexes to spk solves:
new_unchecked()constructors to spk schema objects #1337spk repo indexsubcommand for index generation and updates #1340version_filterfield in index schema #1344