WIP: Pluggable datastore design doc and proof of concept implementation#6888
Draft
tjons wants to merge 10 commits into
Draft
WIP: Pluggable datastore design doc and proof of concept implementation#6888tjons wants to merge 10 commits into
tjons wants to merge 10 commits into
Conversation
tjons
requested review from
MarcosDY,
amartinezfayo,
evan2645,
rturner3 and
sorindumitru
as code owners
Proof of concept for using pluggable datastores Signed-off-by: tjons <tylerschade99@gmail.com>
Signed-off-by: tjons <tylerschade99@gmail.com>
Signed-off-by: tjons <tylerschade99@gmail.com>
Signed-off-by: tjons <tylerschade99@gmail.com>
Signed-off-by: tjons <tylerschade99@gmail.com>
Signed-off-by: tjons <tylerschade99@gmail.com>
Signed-off-by: tjons <tylerschade99@gmail.com>
Signed-off-by: tjons <tylerschade99@gmail.com>
Signed-off-by: tjons <tylerschade99@gmail.com>
Signed-off-by: tjons <tylerschade99@gmail.com>
tjons
force-pushed
the
tjons/pluggable-datastore-cassandra
branch
from
c1a1dce to
fedf7e5
Compare
| existingBundle, err := p.fetchBundle(ctx, req.Bundle.TrustDomainId) | ||
| if err != nil { | ||
| return nil, err | ||
| } |
Member
There was a problem hiding this comment.
To prefix this, I'm not familiar with Cassandra at all. How does this handle concurrent updates of the bundle. E.g. two spire-server deciding they need to renew their keys at the same time. Is there something preventing them for overwriting their changes? Does it have something like transactions or compare and swap?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check list
Affected functionality
This pull request advances #5993 by providing a proof of concept and a running (with some issues) implementation of pluggability in the SPIRE Server's datastore layer. This pull request is a proof of concept, not a proposed change in its current state.
Description of change
Design doc (also WIP, needs some fleshing out) can be found in
pkg/server/plugin/datastore/README.md.This is a proof-of-concept implementation of supporting datastore plugins in the SPIRE server. It makes core changes to
spireandspire-plugin-sdkto support "pluggability" of the datastore. Included is a prototype reference implementation using Apache Cassandra as a backing datastore for SPIRE server. It leverages Cassandra 5.0 and is not compatible with earlier versions of Cassandra due to heavily leveraging Storage-Attached Indexes to improve query performance.Related changes to https://github.com/spiffe/spire-plugin-sdk in support of this POC can be found here: geico/spire-plugin-sdk@b38c1ed. To avoid unnecessary noise, I did not include a PR for this part of the POC as I felt it was not justified to propose official SDK changes at the POC stage.