Update Envoy examples to the v3 API#391
Open
v0lkan wants to merge 3 commits into
Open
Conversation
✅ Deploy Preview for spiffe ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
The inline Envoy config snippets still used the v2 API, which was removed from Envoy in 1.17 and no longer works on any current release. Convert all three snippets to v3, mirroring the maintained configs in spiffe/spire-tutorials (k8s/envoy-x509): - SPIRE Agent cluster: replace the deprecated hosts/pipe syntax with load_assignment and a pipe endpoint address. - TLS certificates: replace tls_context with a transport_socket using envoy.transport_sockets.tls and a typed DownstreamTlsContext, and set resource_api_version/transport_api_version to V3 in sds_config. - Validation context: use combined_validation_context so SPIRE supplies the trust bundle over SDS while a static default_validation_context can match peer SPIFFE IDs via match_typed_subject_alt_names. Adjust the surrounding prose to name the v3 constructs and note the Envoy versions the examples apply to. Fixes #218 Signed-off-by: Volkan Özçelik <volkan.ozcelik@broadcom.com>
sorindumitru
reviewed
Jul 6, 2026
Co-authored-by: Sorin Dumitru <sorin@returnze.ro>
Member
Author
|
Landing this after CI passes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The inline Envoy config snippets still used the v2 API, which was removed from Envoy in 1.17 and no longer works on any current release. Convert all three snippets to v3, mirroring the maintained configs in spiffe/spire-tutorials (k8s/envoy-x509):
Adjust the surrounding prose to name the v3 constructs and note the Envoy versions the examples apply to.
Fixes #218