Sending and Receiving silent payments as a plugin#10526
Closed
securitybrahh wants to merge 1 commit intospesmilo:masterfrom
Closed
Sending and Receiving silent payments as a plugin#10526securitybrahh wants to merge 1 commit intospesmilo:masterfrom
securitybrahh wants to merge 1 commit intospesmilo:masterfrom
Conversation
Author
|
wanted to know how to add tests for a plugin? |
Member
Have you read my concerns about the serious shortcomings and tradeoffs of that implementation? |
Member
|
Sorry but I do not want new plugins to be merged, unless they have shown to be extremely popular. Please distribute your plugin as an external plugin, and submit it to https://plugins.electrum.org The reason is, we need to focus and prioritize our own code development. Support for external plugins has been added in order to reduce the workload on developers, so that they do not spend their time serving requests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am trying to implement silent payments as a plugin
I will wait till bitcoin-core/secp256k1#1765 is merged
Taking #9900 as inspiration
The index server as https://github.com/cake-tech/blockstream-electrs/tree/cake-update-v1
server specification as https://github.com/silent-payments/bIP0352-index-server-specification