Skip to content

Security: Prototype pollution vector via query-parameter configuration override #5225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomaioo wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −1
Open

Security: Prototype pollution vector via query-parameter configuration override #5225

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fbcd783
fix(core): prototype pollution vector via query-parameter con
tomaioo Apr 23, 2026
c4c1066
Merge branch 'main' into fix/security/prototype-pollution-vector-via-…
marcoscaceres Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/core/override-configuration.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ export const name = "core/override-configuration";
*/
export function run(config) {
const params = new URLSearchParams(document.location.search);
const dangerousKeys = new Set(["__proto__", "prototype", "constructor"]);
const overrideEntries = Array.from(params)
.filter(([key, value]) => !!key && !!value)
.map(([codedKey, codedValue]) => {
Expand All @@ -26,7 +27,8 @@ export function run(config) {
value = decodedValue;
}
return [key, value];
});
})
.filter(([key]) => !dangerousKeys.has(key));
const overrideProps = Object.fromEntries(overrideEntries);
Object.assign(config, overrideProps);
pub("amend-user-config", overrideProps);
Expand Down