feat: add local Safari testing via safaridriver

.github/workflows/pr.yml

@@ -33,7 +33,7 @@ jobs:
           echo "::error::Uh oh! builds/ was changed."; exit 1
       - uses: pnpm/action-setup@v5
       - uses: actions/setup-node@v6
-        with: { node-version-file: '.nvmrc', cache: pnpm }
+        with: { node-version-file: ".nvmrc", cache: pnpm }
       - run: pnpm i --frozen-lockfile
       - run: pnpm lint
 
@@ -45,7 +45,7 @@ jobs:
       - uses: actions/checkout@v6
       - uses: pnpm/action-setup@v5
       - uses: actions/setup-node@v6
-        with: { node-version-file: '.nvmrc', cache: pnpm }
+        with: { node-version-file: ".nvmrc", cache: pnpm }
       - run: pnpm i --frozen-lockfile
       - run: pnpm test:build
       - run: pnpm build:w3c
@@ -55,14 +55,23 @@ jobs:
     name: Karma Unit Tests (${{ matrix.browser }})
     strategy:
       matrix:
-        browser: [ChromeHeadless, FirefoxHeadless]
-    runs-on: ubuntu-latest
+        include:
+          - browser: ChromeHeadless
+            os: ubuntu-latest
+          - browser: FirefoxHeadless
+            os: ubuntu-latest
+          - browser: Safari
+            os: macos-latest
+    runs-on: ${{ matrix.os }}
     needs: lint
     steps:
       - uses: actions/checkout@v6
       - uses: pnpm/action-setup@v5
       - uses: actions/setup-node@v6
-        with: { node-version-file: '.nvmrc', cache: pnpm }
+        with: { node-version-file: ".nvmrc", cache: pnpm }
+      - name: Enable Safari WebDriver
+        if: matrix.browser == 'Safari'
+        run: sudo safaridriver --enable
       - run: pnpm i --frozen-lockfile
       - run: pnpm build:w3c & pnpm build:geonovum
       - run: pnpm test:unit
@@ -80,7 +89,7 @@ jobs:
       - uses: actions/checkout@v6
       - uses: pnpm/action-setup@v5
       - uses: actions/setup-node@v6
-        with: { node-version-file: '.nvmrc', cache: pnpm }
+        with: { node-version-file: ".nvmrc", cache: pnpm }
       - run: pnpm i --frozen-lockfile
       - run: pnpm build:w3c
       - name: run validator

.github/workflows/push.yml

@@ -30,7 +30,7 @@ jobs:
       - uses: actions/checkout@v6
       - uses: pnpm/action-setup@v5
       - uses: actions/setup-node@v6
-        with: { node-version-file: '.nvmrc', cache: pnpm }
+        with: { node-version-file: ".nvmrc", cache: pnpm }
       - run: pnpm i --frozen-lockfile
       - run: pnpm build:w3c
       - run: pnpm test:headless
@@ -55,9 +55,27 @@ jobs:
       - uses: actions/checkout@v6
       - uses: pnpm/action-setup@v5
       - uses: actions/setup-node@v6
-        with: { node-version-file: '.nvmrc', cache: pnpm }
+        with: { node-version-file: ".nvmrc", cache: pnpm }
       - run: pnpm i --frozen-lockfile
       - run: pnpm build:w3c & pnpm build:geonovum
       - run: pnpm test
         env:
           BROWSERS: ChromeHeadless
+
+  test-karma-safari:
+    name: Karma Unit Tests (Safari)
+    runs-on: macos-latest
+    steps:
+      - uses: actions/checkout@v6
+      - uses: pnpm/action-setup@v5
+      - uses: actions/setup-node@v6
+        with: { node-version-file: ".nvmrc", cache: pnpm }
+      - run: sudo safaridriver --enable
+      - run: pnpm i --frozen-lockfile
+      - run: pnpm build:w3c & pnpm build:geonovum
+      - run: pnpm test:unit
+        env:
+          BROWSERS: Safari
+      - run: pnpm test:integration
+        env:
+          BROWSERS: Safari

src/core/highlight.js

@@ -30,7 +30,7 @@ async function highlightElement(elem) {
   const languages = getLanguageHint(htmlElem.classList);
   let response;
   try {
-    response = await sendHighlightRequest(htmlElem.innerText, languages);
+    response = await sendHighlightRequest(htmlElem.textContent, languages);
   } catch (err) {
     console.error(err);
     return;

src/core/markdown.js

@@ -64,16 +64,17 @@ class Renderer extends marked.Renderer {
   }
 
   /**
-   * @param {string} infoString
+   * @param {string | undefined} infoString
    */
   static parseInfoString(infoString) {
-    const firstSpace = infoString.search(/\s/);
+    const str = infoString || "";
+    const firstSpace = str.search(/\s/);
     if (firstSpace === -1) {
-      return { language: infoString };
+      return { language: str };
     }
 
-    const language = infoString.slice(0, firstSpace);
-    const metaDataStr = infoString.slice(firstSpace + 1);
+    const language = str.slice(0, firstSpace);
+    const metaDataStr = str.slice(firstSpace + 1);
     let metaData;
     if (metaDataStr) {
       try {

src/core/pubsubhub.js

@@ -24,7 +24,23 @@ export function pub(topic, detail) {
   }
   // If this is an iframe, postMessage parent (used in testing).
   const args = String(JSON.stringify(detail?.stack || detail));
-  window.parent.postMessage({ topic, args }, window.parent.location.origin);
+  // Safari can throw SecurityError accessing parent.location.origin from
+  // srcdoc iframes (treated as opaque origin). For the "end-all" signal
+  // (detail = undefined, no sensitive data) fall back to "*" so the test
+  // harness receives it. For all other topics skip the postMessage entirely
+  // to avoid broadcasting potentially sensitive data to unknown origins.
+  let targetOrigin;
+  try {
+    targetOrigin = window.parent.location.origin;
+  } catch {
+    if (topic !== "end-all") return;
+    targetOrigin = "*";
+  }
+  try {
+    window.parent.postMessage({ topic, args }, targetOrigin);
+  } catch {
+    // Ignore: postMessage may throw in restricted browsing contexts.
+  }
 }
 
 /**

tests/karma.conf.base.cjs

@@ -46,7 +46,7 @@ module.exports = config => {
       require("karma-jasmine-html-reporter"),
       require("karma-chrome-launcher"),
       require("karma-firefox-launcher"),
-      require("karma-safari-launcher"),
+      require("./karma.safari.cjs"),
     ],
     frameworks: ["jasmine"],
     files,