Add ability to extend Mavis forms/extractors/tests for internal forks#129
Open
bdutro-mips wants to merge 16 commits intomainfrom
Open
Add ability to extend Mavis forms/extractors/tests for internal forks#129bdutro-mips wants to merge 16 commits intomainfrom
bdutro-mips wants to merge 16 commits intomainfrom
Conversation
Add tests to Github actions
Test C++20 and C++23
klingaard
reviewed
Apr 25, 2026
Member
There was a problem hiding this comment.
Curious, I assume this header/template is only included with the FormRegistry, right? In other words, in the model, this header is never seen. The reason I ask is 'cause of increased compile times which I've always battled with Mavis.
Collaborator
Author
There was a problem hiding this comment.
It's included once in FormRegistry.cpp and once in ExtractorRegistry.cpp
klingaard
approved these changes
Apr 25, 2026
Member
klingaard
left a comment
There was a problem hiding this comment.
Thank you, Thank you, Thank you for adding a proper regression and CI!!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has 3 changes to make life easier for those who have to maintain internal Mavis forks:
cmake/internal.cmakeINTERNAL_EXTRACTOR_REGISTRY: the class name of an additional extractor registry for non-public extractor definitionsINTERNAL_EXTRACTOR_REGISTRY_HEADER: the name of the header file whereINTERNAL_EXTRACTOR_REGISTRYis definedINTERNAL_FORM_REGISTRY: the class name of an additional form registry for non-public form definitionsINTERNAL_FORM_REGISTRY_HEADER: the name of the header file whereINTERNAL_FORM_REGISTRYis definedriscv_isa_spec.json) now support anincludesfield that can be used to include additional ISA spec JSONsI also added a
make regresstarget and added the regression tests to the pre-merge checks.