fix: coauthors are being dropped - #248
Open
justinbaltazar wants to merge 1 commit into
Open
Conversation
justinbaltazar
marked this pull request as ready for review
February 23, 2026 17:51
Author
|
@spacedentist Can you please take a look? I'm wondering if this should be configurable, but it sounds more like we should probably just support this out of the box? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that coauthors are being dropped when running
spr diff. Instead of being persisted to the commit history, it's instead showing up the PR description.This is leading to attribution issues on merge (ex: if a commit was coauthored by Claude, this piece of metadata is lost).
This change modifies how commits are parsed and ensures that the
Co-Authored-Bytrailers are preserved. It also ensures that these trailers are not added to the PR description.Before
After