Fix spec-compliance ordering issue on HTTP caching headers#1019
Merged
Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
🤖 Augment PR SummarySummary: This PR fixes HTTP cache precondition ordering in artifact serving to better align with RFC 9110. Changes:
Technical Notes: The new tests validate that a non-matching 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 2 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
There was a problem hiding this comment.
2 issues found across 2 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Benchmark Index (community)
Details
| Benchmark suite | Current: 4243951 | Previous: 87a5ab6 | Ratio |
|---|---|---|---|
Add one schema (0 existing) |
399 ms |
418 ms |
0.95 |
Add one schema (100 existing) |
30 ms |
28 ms |
1.07 |
Add one schema (1000 existing) |
91 ms |
85 ms |
1.07 |
Add one schema (10000 existing) |
744 ms |
688 ms |
1.08 |
Update one schema (1 existing) |
22 ms |
27 ms |
0.81 |
Update one schema (101 existing) |
30 ms |
28 ms |
1.07 |
Update one schema (1001 existing) |
93 ms |
87 ms |
1.07 |
Update one schema (10001 existing) |
753 ms |
697 ms |
1.08 |
Cached rebuild (1 existing) |
7 ms |
6 ms |
1.17 |
Cached rebuild (101 existing) |
9 ms |
8 ms |
1.13 |
Cached rebuild (1001 existing) |
31 ms |
29 ms |
1.07 |
Cached rebuild (10001 existing) |
283 ms |
248 ms |
1.14 |
Index 100 schemas |
657 ms |
635 ms |
1.03 |
Index 1000 schemas |
1357 ms |
1613 ms |
0.84 |
Index 10000 schemas |
13704 ms |
13599 ms |
1.01 |
Index 10000 schemas (custom meta-schema) |
135611 ms |
144866 ms |
0.94 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Benchmark Index (enterprise)
Details
| Benchmark suite | Current: 4243951 | Previous: 87a5ab6 | Ratio |
|---|---|---|---|
Add one schema (0 existing) |
388 ms |
383 ms |
1.01 |
Add one schema (100 existing) |
35 ms |
32 ms |
1.09 |
Add one schema (1000 existing) |
97 ms |
88 ms |
1.10 |
Add one schema (10000 existing) |
778 ms |
733 ms |
1.06 |
Update one schema (1 existing) |
27 ms |
24 ms |
1.13 |
Update one schema (101 existing) |
35 ms |
31 ms |
1.13 |
Update one schema (1001 existing) |
97 ms |
90 ms |
1.08 |
Update one schema (10001 existing) |
792 ms |
717 ms |
1.10 |
Cached rebuild (1 existing) |
8 ms |
7 ms |
1.14 |
Cached rebuild (101 existing) |
11 ms |
10 ms |
1.10 |
Cached rebuild (1001 existing) |
34 ms |
30 ms |
1.13 |
Cached rebuild (10001 existing) |
286 ms |
243 ms |
1.18 |
Index 100 schemas |
661 ms |
670 ms |
0.99 |
Index 1000 schemas |
1629 ms |
1638 ms |
0.99 |
Index 10000 schemas |
13903 ms |
13767 ms |
1.01 |
Index 10000 schemas (custom meta-schema) |
142862 ms |
141561 ms |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com