Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
🤖 Augment PR SummarySummary: This PR updates artifact serving to use weak ETags when the response is gzip-encoded, aligning validator strength with RFC 9110. Changes:
Technical Notes: The checksum is computed over the identity payload at index time, so gzip wire bytes require weak validation semantics. 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 2 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Benchmark Index (community)
Details
| Benchmark suite | Current: 7baa9fc | Previous: b6a5872 | Ratio |
|---|---|---|---|
Add one schema (0 existing) |
387 ms |
399 ms |
0.97 |
Add one schema (100 existing) |
30 ms |
30 ms |
1 |
Add one schema (1000 existing) |
91 ms |
93 ms |
0.98 |
Add one schema (10000 existing) |
739 ms |
777 ms |
0.95 |
Update one schema (1 existing) |
22 ms |
22 ms |
1 |
Update one schema (101 existing) |
31 ms |
30 ms |
1.03 |
Update one schema (1001 existing) |
93 ms |
92 ms |
1.01 |
Update one schema (10001 existing) |
749 ms |
782 ms |
0.96 |
Cached rebuild (1 existing) |
7 ms |
7 ms |
1 |
Cached rebuild (101 existing) |
9 ms |
9 ms |
1 |
Cached rebuild (1001 existing) |
31 ms |
31 ms |
1 |
Cached rebuild (10001 existing) |
272 ms |
277 ms |
0.98 |
Index 100 schemas |
486 ms |
572 ms |
0.85 |
Index 1000 schemas |
1375 ms |
1475 ms |
0.93 |
Index 10000 schemas |
13895 ms |
13778 ms |
1.01 |
Index 10000 schemas (custom meta-schema) |
137246 ms |
135908 ms |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Benchmark Index (enterprise)
Details
| Benchmark suite | Current: 7baa9fc | Previous: b6a5872 | Ratio |
|---|---|---|---|
Add one schema (0 existing) |
388 ms |
396 ms |
0.98 |
Add one schema (100 existing) |
32 ms |
34 ms |
0.94 |
Add one schema (1000 existing) |
90 ms |
91 ms |
0.99 |
Add one schema (10000 existing) |
856 ms |
729 ms |
1.17 |
Update one schema (1 existing) |
24 ms |
26 ms |
0.92 |
Update one schema (101 existing) |
32 ms |
33 ms |
0.97 |
Update one schema (1001 existing) |
93 ms |
91 ms |
1.02 |
Update one schema (10001 existing) |
758 ms |
746 ms |
1.02 |
Cached rebuild (1 existing) |
8 ms |
8 ms |
1 |
Cached rebuild (101 existing) |
9 ms |
10 ms |
0.90 |
Cached rebuild (1001 existing) |
31 ms |
30 ms |
1.03 |
Cached rebuild (10001 existing) |
259 ms |
257 ms |
1.01 |
Index 100 schemas |
658 ms |
496 ms |
1.33 |
Index 1000 schemas |
1646 ms |
1580 ms |
1.04 |
Index 10000 schemas |
13985 ms |
14527 ms |
0.96 |
Index 10000 schemas (custom meta-schema) |
145994 ms |
153703 ms |
0.95 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com