Conversation
This reverts commit c400ce1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This branch extends starcheck’s planet handling from plot-only visibility to review output.
Before this change, starcheck plots would display planet positions (via chandra_aca plotting support), but starcheck did not run planet checks. With this change, starcheck now runs the sparkles planet checks during processing and emits text messages in the starcheck report:
Additional changes (separate from planet warning behavior)
processing summary parsing improvement for maneuver matching
For pre-2020 ER-style/non-numeric dot obsid cases, maneuver setup now uses processing-summary content to map dot obsid values to numeric obsids before matching MP_TARGQUAT maneuvers. This makes maneuver association more robust for older loads. (this is largely done so that earlier loads with planets can be successfully run in modern starcheck for testing, but the changes are benign for modern loads).
Debug catalog pickle output
A new command-line option allows saving generated proseco catalogs to a pickle file for debugging/regression analysis workflows.
Proseco argument enrichment
Starcheck now passes additional context (including duration and target name) into the proseco/sparkles path used for these checks.
Requirements
sot/chandra_aca#203
sot/proseco#415
sot/sparkles#229
Interface impacts
Testing
Unit tests
Independent check of unit tests by [REVIEWER NAME]
Functional tests
Regression testing via a set of weekly schedules with known planets:
https://icxc.cfa.harvard.edu/aspect/test_review_outputs/starcheck/starcheck-planets/combined_diff.txt
Functional testing is in the sparkles PR.