feat [github, slack-blocks, mumu]: PR 리뷰 재요청 Slack 알림 추가#33
Open
feat [github, slack-blocks, mumu]: PR 리뷰 재요청 Slack 알림 추가#33
Conversation
jeonghoon11
approved these changes
Apr 23, 2026
Member
jeonghoon11
left a comment
jeonghoon11
left a comment
There was a problem hiding this comment.
고생했어요!! 최고의 챕터장을 둬서 많이 배우네요 🥹 잘 쓸게욥!!!
| }; | ||
|
|
||
| /** PR 스레드에 리뷰 재요청 reply를 생성합니다. */ | ||
| export const createPullRequestReRequestedReply = async ( |
Member
There was a problem hiding this comment.
이 함수가 바로 위의 createPullRequestReviewCommentReply와 동작이 거의 같아 보이는것 갘아요! Slack에 보낼 메시지를 만드는 부분만 다르고 thread 조회, chat.postMessage 호출, 실패 처리 흐름은 동일한 것 같아요. 그래서 두 함수를 그대로 유지하면서 둘다 reply에 해당하는 내용이니 공통 reply 전송 로직만 내부 함수로 분리하는건 어떤가욥??
Comment on lines
+25
to
+31
| { | ||
| type: "section", | ||
| text: { | ||
| type: "mrkdwn", | ||
| text: `> *PR:* <${prUrl}|#${prNumber} ${title}>`, | ||
| }, | ||
| }, |
Member
There was a problem hiding this comment.
처음 스레드가 만들어질 때 PR과 PR번호, 제목이 보이는데 스레드에 코멘트가 쌓였을 때 상단으로 이동하지 않고 바로 확인하기 위해서 넣은건가욥?? Just Wonder!
ExceptAnyone
approved these changes
Apr 27, 2026
Comment on lines
+9
to
+11
|
|
||
| export const blocks = (payload: PullRequestReviewRequested, options: PR리뷰재요청Options): KnownBlock[] => { | ||
| const { pull_request } = payload; |
Member
There was a problem hiding this comment.
예전에 주용님 리뷰에도 달았던건데, blocks가 뭘 의미하는건가요?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
작업 내용
review_requestedwebhook 이벤트를 위한 Zod 스키마 및 타입 추가 (pullRequestReviewRequestedSchema)PR_재리뷰) 추가review_requested액션 핸들러 추가createPullRequestReRequestedReply함수 추가