This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Remove PacketDeserializer's extra overflow guard#29715
Merged
ryoqun merged 1 commit intoJan 17, 2023
Merged
Conversation
This was referenced Jan 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(no rush; no need to work on weekend)
Problem
as discussed here (https://github.com/solana-labs/solana/pull/25172/files#r1044407292), overflow check isn't needed and is inconsistent even with nearby code.
Summary of Changes
just remove it along side with some cleanings
as pointed here (#29196 (comment)), this change must preceed prior to my banking tracer pr: #29196
cc: @apfitzge, @ryleung-solana
Fixes #