docs: document Studio UI build inputs#681
Draft
sueun-dev wants to merge 1 commit into
Draft
Conversation
Collaborator
|
@sueun-dev you have this marked as a draft. Is it ready for review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
STUDIO_UI_VERSIONfor pinning a releasedstudio-dist.zipSTUDIO_UI_DISTfor sandboxed or local builds that already have a pre-built Studio zipContext
crates/studio/build.rsalready supports these inputs, and #628 addedSTUDIO_UI_DISTfor sandbox builds. The README source-build path currently only showscargo surfpool-install, so contributors have to read the build script to find the supported knobs.Related to #588.
Test Plan
git diff --checkcargo test -p surfpool-cli public_service_url -- --nocapturecargo test -p surfpool-cli default_public_host -- --nocapture