New GaussianConvolution & GaussianSqrtConvolution classes; Update to Scale systematic#84
Open
dcookman wants to merge 5 commits into
Open
New GaussianConvolution & GaussianSqrtConvolution classes; Update to Scale systematic#84dcookman wants to merge 5 commits into
dcookman wants to merge 5 commits into
Conversation
…dify Gaussian(Fitter) to allow hiding of mean(s).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does a number of things, but its primary aim is the creation of two new "ready-to-use" Systematic classes that have been much asked for:
GaussianConvolutionandGaussianSqrtConvolution. These both derive from the underlyingConvolutionclass, handling the special case of a 1D Gaussian smearing kernel; the latter also includes a square root scaling dependence to the kernel's width that is often used when smearing along an energy axis.Because of various special properties that a Gaussian kernel has, the
ConstructSubMatrix()method was overloaded in both classes to allow for much faster response matrix generation. This was achieved through two main tricks:GaussianConvolutionwith constant bin widths) the calculated contributions will often be highly repeated; we now cache results and check to see if they've already been calculated.Further updates were made to support these new classes:
GaussianConvolutionclass to have theFitComponentinterface accessing the sigma of the Gaussian only, not the mean (which is irrelevant during a smearing convolution). A new option toHideMeanParameters()was added within theGaussianandGaussianFitterclasses to support this.privatemembers/methods of the underlyingConvolutionclass are updated to beingprotected, so that our new classes can access them.In addition, an update to the
Scalesystematic'sConstruct()method was made so that one singleSetComponents()call was made instead of many individualSetComponent()calls. This should hopefully makeScalethat bit faster too.