Skip to content

add limits to external requests for solana_service#1559

Open
Unheilbar wants to merge 10 commits into
feature/solcap-read_triggerfrom
PLEX-2936/limit-size-for-external-requests
Open

add limits to external requests for solana_service#1559
Unheilbar wants to merge 10 commits into
feature/solcap-read_triggerfrom
PLEX-2936/limit-size-for-external-requests

Conversation

@Unheilbar
Copy link
Copy Markdown
Contributor

@Unheilbar Unheilbar commented May 18, 2026

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 18, 2026

📊 API Diff Results

No changes detected for module github.com/smartcontractkit/chainlink-solana/contracts

View full report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 18, 2026

📊 API Diff Results

No changes detected for module github.com/smartcontractkit/chainlink-solana/integration-tests

View full report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 18, 2026

⚠️ API Diff Results - github.com/smartcontractkit/chainlink-solana

⚠️ Breaking Changes (1)

pkg/solana/config.Workflow (1)
  • RequestSizeLimit — ➕ Added

✅ Compatible Changes (2)

github.com/smartcontractkit/chainlink-common/pkg/types.(*UnimplementedRelayer) (1)
  • Stellar — ➕ Added
pkg/solana/config.WorkflowConfig (1)
  • RequestSizeLimit — ➕ Added

📄 View full apidiff report

@Unheilbar Unheilbar changed the base branch from develop to feature/solcap-read_trigger May 27, 2026 13:02
- name: Run golangci-lint (integration-tests)
if: ${{ always() && !contains(join(github.event.pull_request.labels.*.name, ' '), 'allow-lint-issues') }}
uses: smartcontractkit/.github/actions/ci-lint-go@cdcf67030997adc322ddb2ad48949f394f5b04a3 #ci-lint-go/3.0.0
uses: smartcontractkit/.github/actions/ci-lint-go@ci-lint-go/v4
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cl-common bump bumped go to 1.26, so I had to bump lint image as well

Comment thread pkg/solana/solana_service.go
@cl-sonarqube-production
Copy link
Copy Markdown

Quality Gate failed Quality Gate failed

Failed conditions
40.0% Coverage on New Code (required ≥ 75%)

See analysis details on SonarQube

@Unheilbar Unheilbar marked this pull request as ready for review May 29, 2026 13:15
@Unheilbar Unheilbar requested review from a team as code owners May 29, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants