Skip empty SANs - #867
Merged
Merged
Skip empty SANs#867
Conversation
With this commit we will skip empty SANs when rendering a template and building a X509 certificate from it. Go 1.25.2 will fails to parse a certificate if for example the DNS is an empty string.
maraino
force-pushed
the
mariano/empty-sans
branch
from
October 10, 2025 23:46
f8817fa to
067c99c
Compare
dopey
approved these changes
Oct 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this commit we will skip empty SANs when rendering a template and building a X509 certificate from it.
Go 1.25.2 will fails to parse a certificate if for example the DNS is an empty string.