fix(acme): reject General JWS serialization (#2642) - #2798
Open
Tyagiquamar wants to merge 1 commit into
Open
Tyagiquamar wants to merge 1 commit into
Tyagiquamar wants to merge 1 commit into
Conversation
ACME requests MUST use the Flattened JSON Serialization (RFC 8555, Section 6.2), but parseJWS accepted the General serialization (RFC 7515, Section 7.2.1) because go-jose parses both. A single-signature General JWS also slipped past the more-than-one signature check in validateJWS, so reject bodies carrying a top-level signatures member before parsing. Fixes smallstep#2642
|
Tyagiquamar seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Author
|
Hi, just following up on this when you get a chance. The branch is up to date and checks are green. If it looks good from your side, it should be ready to merge. Happy to make any changes if needed. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rejects ACME POST bodies using the General JWS JSON Serialization. RFC 8555 Section 6.2 requires the Flattened JSON Serialization, but
parseJWSaccepted the General form because go-joseParseSignedparses both, and a single-signature General JWS also passed the more-than-one-signature check invalidateJWS. The middleware now returns amalformederror for bodies carrying a top-levelsignaturesmember before parsing.Fixes #2642.
Verification (all in
golang:1.26-bookworm, matching go.modgo 1.26.0):gofmt -l acme/api/-> no output, exit 0go vet ./acme/api/-> exit 0go build ./acme/...-> exit 0go test ./acme/... -count=1-> ok all 4 packages (acme, acme/api, acme/db/nosql, acme/wire), exit 0TestHandler_parseJWS/fail/general-jws-serializationcase fails without the fix (General JWS accepted) and passes with it.