Repository navigation
Aktualizuj core s obmedzením XSLT a zrovnaj Saxon na 12.10 - #32
Open
celuchmarek wants to merge 2 commits into
Open
celuchmarek wants to merge 2 commits into
celuchmarek wants to merge 2 commits into
Conversation
Pull in the XSLT resource-access hardening (restrict protocols and collections, disable the transform() function and saxon: vendor functions) from autogram-core, porting the Autogram fix for GHSA-2xch-hq7r-8hr5 to the service. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vfj774yCbs76zuQnVyduVN
Align the Saxon version with autogram-core and Autogram (desktop), and advance the core submodule to the matching bump. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vfj774yCbs76zuQnVyduVN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
avm-servicespracúva XSLT transformácie z nedôveryhodných požiadaviek (napr.POST /visualization). Použitá verziacoreešte nemala ochranu proti podvrhnutým štýlom — rovnakú zraniteľnosť, akú Autogram (desktop) riešil ako GHSA-2xch-hq7r-8hr5. Cez podvrhnuté XSLT (napr. vnorenéfn:transform()s vlastnou Saxon konfiguráciou) tak útočník vedel zo servera prečítať lokálne súbory alebo robiť sieťové požiadavky.Navyše bola verzia Saxon‑HE rozbitá:
service/pom.xmlajcorepoužívali12.4, kým Autogram je na12.10.Solution
corena opravený commit, ktorý obmedzuje prístup XSLT k zdrojom a zakazujefn:transform()/saxon:vendor funkcie. Samotná oprava je v Obmedz prístup XSLT k zdrojom a zakáž funkciu transform() autogram-core#20.saxon.versionvservice/pom.xmlna12.10, čím je verzia zrovnaná scoreaj s Autogramom.Mimo rozsahu: žiadne zmeny v kóde
service/— iba posun závislosti a submodulu. Overenie:mvn -pl service test(12 testov zelených) a build celého projektu.Demo
End‑to‑end proti reálne spustenému
avm-service(POST /visualization) s rovnakou požiadavkou — škodlivé XSLT, ktoré cez vnorenýtransform()číta lokálny súbor:Generated by Claude Code