Skip to content

Fix: denominator_corrected_rules/v1 invalid result for complex queries#805

Open
r3code wants to merge 1 commit intoslok:mainfrom
r3code:denominator_corrected_rules-fix
Open

Fix: denominator_corrected_rules/v1 invalid result for complex queries#805
r3code wants to merge 1 commit intoslok:mainfrom
r3code:denominator_corrected_rules-fix

Conversation

@r3code
Copy link
Copy Markdown
Contributor

@r3code r3code commented Apr 1, 2026

Closes #804

@r3code r3code requested a review from slok as a code owner April 1, 2026 17:05
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 1, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 30.84%. Comparing base (3757b66) to head (13cfe17).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...o/contrib/denominator_corrected_rules_v1/plugin.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #805   +/-   ##
=======================================
  Coverage   30.84%   30.84%           
=======================================
  Files         141      141           
  Lines        8689     8689           
=======================================
  Hits         2680     2680           
  Misses       5770     5770           
  Partials      239      239           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Closes slok#804

Signed-off-by: Dmitriy S. Sinyavskiy <contact@r3code.ru>
@r3code r3code force-pushed the denominator_corrected_rules-fix branch from 13b6eec to 13cfe17 Compare April 1, 2026 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

denominator_corrected_rules/v1 invalid result for complex queries

2 participants