perf: virtual scroll for overview and quick overview#1610
perf: virtual scroll for overview and quick overview#1610jakobkordez wants to merge 14 commits intoslidevjs:mainfrom
Conversation
✅ Deploy Preview for slidev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Thanks for your contribution! There is a problem that the height of the rows is calculated dynamically, but the |
Fixed. |
|
Don't merge yet, fixing something |
|
Ok, that's all |
|
I am not very sure about this - after this PR, every time you open up the overview, every slide gets re-initiated, which they are supposed to be cached. If perf/memory is really a concern, I'd suggest we take a screenshot of the final slide and place the overview with that image (with an option to opt-in/out) so we don't duplicate slides rendering and would be a lot more performant than virtual scroll. |
|
If you need a large presentation for testing try: https://gitlab.vegova.si/rkv/prosojnice |
|
@antfu Are you sure the slides are not getting cached? It seems to me they are: the loading component only shows the first time the page is opened |
Fixes slow loading and scrolling for large presentations