Skip to content

fix(paginator): low contrast + selected state #3289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
michal-sanoma wants to merge 9 commits into
base: main
Choose a base branch
from
+41 −26
Open

fix(paginator): low contrast + selected state #3289

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
35b9d7a
chore(paginator): low contrast + selected state
michal-sanoma May 8, 2026
9a7ef93
Merge branch 'main' into fix/2708_paginator_low_contrast
michal-sanoma May 19, 2026
b8e2ff1
Merge branch 'main' into fix/2708_paginator_low_contrast
michal-sanoma May 21, 2026
ad31d1d
chore(paginator): low contrast + selected state
michal-sanoma May 21, 2026
6f16aee
chore(paginator): low contrast + selected state
michal-sanoma May 21, 2026
3bdc185
chore(paginator): low contrast + selected state
michal-sanoma May 22, 2026
e715e6c
Merge branch 'main' into fix/2708_paginator_low_contrast
michal-sanoma May 22, 2026
89e2e33
chore(paginator): low contrast + selected state
michal-sanoma May 22, 2026
273128f
chore(paginator): low contrast + selected state
michal-sanoma May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions packages/components/button/src/button.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,12 +232,13 @@ button {
appearance: none;
background: color-mix(
in srgb,
var(--_bg-color),
var(--_bg-mix-color) calc(100% * var(--_bg-opacity))
var(--sl-button-bg-color, var(--_bg-color)),
var(--sl-button-bg-mix-color, var(--_bg-mix-color))
calc(100% * var(--sl-button-bg-opacity, var(--_bg-opacity)))
);
Comment thread
michal-sanoma marked this conversation as resolved.
border: var(--sl-size-borderWidth-action) solid var(--sl-color-border-secondary-bold);
border-radius: var(--sl-size-borderRadius-default);
color: var(--sl-color-foreground-secondary-bold);
color: var(--sl-button-color, var(--sl-color-foreground-secondary-bold));
cursor: pointer;
display: inline-flex;
flex: 1;
Expand Down
42 changes: 29 additions & 13 deletions packages/components/paginator/src/paginator.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,24 @@
}

.page {
--sl-button-bg-color: transparent;
--sl-button-bg-mix-color: var(--sl-color-background-neutral-interactive-plain);
--sl-button-bg-opacity: var(--sl-opacity-interactive-plain-idle);
--sl-button-color: var(--sl-color-foreground-neutral-bold);

box-sizing: border-box;
color: var(--sl-color-foreground-neutral-bold);
Comment thread
michal-sanoma marked this conversation as resolved.
Outdated
flex-shrink: 0;
inline-size: calc(1lh + (var(--sl-size-100) * 2));
padding-inline: 0;

&:hover {
--sl-button-bg-opacity: var(--sl-opacity-interactive-plain-hover);
}

&:active {
Comment thread
michal-sanoma marked this conversation as resolved.
Outdated
--sl-button-bg-opacity: var(--sl-opacity-interactive-plain-active);
}
}

:host([size='sm']) {
Expand All @@ -50,30 +63,33 @@
}

.current {
--_bg-color: var(--sl-color-background-selected-subtle);
--_bg-mix-color: var(--sl-color-background-primary-interactive-plain);
--_bg-opacity: var(--sl-opacity-interactive-plain-idle);

color: var(--sl-color-foreground-primary-bold);
--sl-button-bg-color: var(--sl-color-background-selected-subtle);
--sl-button-bg-mix-color: var(--sl-color-background-primary-interactive-plain);
--sl-button-bg-opacity: var(--sl-opacity-interactive-plain-idle);
--sl-button-color: var(--sl-color-foreground-primary-bold);

&:hover {
--_bg-opacity: var(--sl-opacity-interactive-plain-hover);
--sl-button-bg-opacity: var(--sl-opacity-interactive-plain-hover);
}

&:active {
--_bg-opacity: var(--sl-opacity-interactive-plain-active);
--sl-button-bg-opacity: var(--sl-opacity-interactive-plain-active);
}
}

:host([emphasis='bold']) .current {
--_bg-color: var(--sl-color-background-selected-bold);
--_bg-mix-color: var(--sl-color-background-selected-interactive-bold);
--sl-button-bg-color: var(--sl-color-background-selected-bold);
--sl-button-bg-mix-color: var(--sl-color-background-selected-interactive-bold);
--sl-button-color: var(--sl-color-foreground-primary-onBold);
--sl-button-bg-opacity: var(--sl-opacity-interactive-bold-idle);

color: var(--sl-color-foreground-primary-onBold);
}
&:hover {
--sl-button-bg-opacity: var(--sl-opacity-interactive-bold-hover);
}

:host([emphasis='bold']) .current:not(:hover, :active) {
--_bg-opacity: var(--sl-opacity-interactive-bold-idle);
&:active {
--sl-button-bg-opacity: var(--sl-opacity-interactive-bold-active);
}
}

.wrapper {
Expand Down
Loading