Skip to content

[BUG] Fix deep_equals failing on string-dtype numpy arrays (numpy < 2.0) #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shourya1419-netizen wants to merge 9 commits into
base: main
Choose a base branch
from
Open

[BUG] Fix deep_equals failing on string-dtype numpy arrays (numpy < 2.0) #519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7814248
Add regression test ensuring filter_tags does not return empty results
shourya1419-netizen Mar 4, 2026
2bb4b1b
Merge branch 'main' into test-filter-tags-regression
shourya1419-netizen Mar 5, 2026
25d5fc8
fix:runtime code generation
shourya1419-netizen Mar 5, 2026
b142b71
Merge branch 'test-filter-tags-regression' of https://github.com/shou…
shourya1419-netizen Mar 5, 2026
fb34efb
Fix deep_equals failing on string-dtype numpy arrays
shourya1419-netizen Mar 7, 2026
55ce801
Fix deep_equals failing on string-dtype numpy arrays
shourya1419-netizen Mar 7, 2026
44e82f0
lil fix
shourya1419-netizen Mar 7, 2026
f10e5fa
lil fixed
shourya1419-netizen Mar 7, 2026
d315731
Merge branch 'main' into fix_numpy_deep_equals
fkiraly Apr 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions skbase/tests/test_deep_equals.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
def test_deep_equals_numpy_string_array():
"""Test that deep_equals works on string-dtype numpy arrays. GitHub issue #517."""
import numpy as np

from skbase.utils.deep_equals import deep_equals

s = np.array(["1", "2", "1"])
# Same arrays should be equal
assert deep_equals(s, s) is True

# Different arrays should not be equal
t = np.array(["1", "2", "3"])
assert deep_equals(s, t) is False
2 changes: 1 addition & 1 deletion skbase/utils/deep_equals/_deep_equals.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ def _numpy_equals_plugin(x, y, return_msg=False, deep_equals=None):
return ret(False, f".shape, x.shape = {x.shape} != y.shape = {y.shape}")
if x.dtype != y.dtype:
return ret(False, f".dtype, x.dtype = {x.dtype} != y.dtype = {y.dtype}")
if x.dtype == "str":
if x.dtype == "str" or np.issubdtype(x.dtype, np.character):
return ret(np.array_equal(x, y), ".values")
elif x.dtype == "object":
x_flat = x.flatten()
Expand Down
Loading